Add Duration WellKnownType JSON Support #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyp
approved these changes
Oct 28, 2020
| var seconds = dur.seconds | ||
| var nanos = dur.nanos | ||
|
|
||
| return buildString { |
There was a problem hiding this comment.
🔧 A slight performance optimization: pre-allocate the largest length this string can be (which I think is 25 characters) by using buildString(25) {. That way the builder doesn't have to do unnecessary string copies during serialization.
There was a problem hiding this comment.
I believe it's 24: -315576000000.999999999s
nickthegroot
force-pushed
the
json/durations
branch
from
d4a9699 to
1ad19a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another box checked in #72