Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there plan to support Kotlin 1.4? #86

Closed
kainosk opened this issue Sep 3, 2020 · 6 comments · Fixed by #114
Closed

Is there plan to support Kotlin 1.4? #86

kainosk opened this issue Sep 3, 2020 · 6 comments · Fixed by #114
Labels
enhancement New feature or request
Milestone

Comments

@kainosk
Copy link
Contributor

kainosk commented Sep 3, 2020

Is there plan to support Kotlin 1.4?

Thank you for great protobuf library. ❤️ 👍

@garyp
Copy link
Collaborator

garyp commented Sep 3, 2020

Yes definitely. I already have a branch in progress that's on Kotlin 1.4. Unfortunately I ran into some Kotlin compiler bugs and am waiting on 1.4.1 (or whatever the next version will be) to be released.

@garyp
Copy link
Collaborator

garyp commented Sep 5, 2020

The branch is available at https://github.com/streem/pbandk/tree/kotlin-1.4 for anyone interested. As mentioned above, it currently is broken because of some Kotlin compiler bugs.

@kainosk
Copy link
Contributor Author

kainosk commented Sep 7, 2020

Thank you for your reply! I'm very happy to know that there is already a plan to support new Kotlin 1.4(.x) ❤️

You can close this issue or should I? Thanks!

@garyp
Copy link
Collaborator

garyp commented Sep 8, 2020

I'll keep this open until the Kotlin 1.4 support is merged, in case anyone else has the same question.

@garyp garyp added the enhancement New feature or request label Sep 11, 2020
@garyp garyp added this to the 0.10.0 milestone Sep 11, 2020
@garyp garyp linked a pull request Dec 16, 2020 that will close this issue
@garyp garyp removed a link to a pull request Dec 16, 2020
@garyp
Copy link
Collaborator

garyp commented Dec 26, 2020

Quick update: Kotlin 1.4 support seems to be working on the kotlin-1.4 branch of pbandk (thanks to @JeroenMols for help on this). However, the build is failing in CI because it runs out of memory. Next steps for getting this merged in would be to either figure out how to get the build to consume less memory, or to migrate the CI from CircleCI to GitHub Actions (Streem has a paid account on GitHub Actions, which would allow pbandk to use more resources for CI builds than what's available for free on CircleCI).

@garyp
Copy link
Collaborator

garyp commented Dec 27, 2020

Here's an instance of the failure in CI: https://app.circleci.com/pipelines/github/streem/pbandk/357/workflows/c263a7d5-062a-449e-ab24-b9778a8823d3/jobs/895. The build runs out of memory during the :runtime:linkDebugTestLinuxX64 task with the following error:

e: Compilation failed: The /home/circleci/.konan/dependencies/clang-llvm-8.0.0-linux-x86-64/bin/clang++ command returned non-zero exit code: 137.
output:


 * Source files: 
 * Compiler version info: Konan: 1.4.21 / Kotlin: 1.4.21
 * Output kind: PROGRAM

e: org.jetbrains.kotlin.konan.KonanExternalToolFailure: The /home/circleci/.konan/dependencies/clang-llvm-8.0.0-linux-x86-64/bin/clang++ command returned non-zero exit code: 137.

I'm able to replicate the CI failure by running:

docker run --rm -it -m 4g circleci/openjdk:11-jdk-browsers /bin/bash

And then inside the container running the following commands (which mimic the CI environment):

sudo apt update && sudo apt install libncurses5
cd $HOME
git clone https://github.com/streem/pbandk.git
cd pbandk/
git checkout kotlin-1.4
export GRADLE_OPTS="-Dorg.gradle.daemon=false -Dkotlin.compiler.execution.strategy=in-process -Xmx4096m"
./gradlew --no-build-cache build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants