Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example projects to work with pbandk 0.9.0 #37

Closed
garyp opened this issue Apr 29, 2020 · 4 comments
Closed

Update example projects to work with pbandk 0.9.0 #37

garyp opened this issue Apr 29, 2020 · 4 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@garyp
Copy link
Collaborator

garyp commented Apr 29, 2020

The projects in https://github.com/streem/pbandk/tree/master/examples need to be updated to work with the new version of pbandk that uses the Kotlin Multiplatform Plugin. The browser-js example should also be updated to use the newer Kotlin/JS Gradle plugin.

Bonus points if we can update the gradle files to use the Gradle Kotlin DSL at the same time.

@garyp garyp added bug Something isn't working help wanted Extra attention is needed labels Apr 29, 2020
@garyp garyp added this to the 0.9.0 milestone Apr 29, 2020
@garyp garyp mentioned this issue Apr 29, 2020
@tinder-aminghadersohi
Copy link
Contributor

The kotlin dsl task sounds like it should be decoupled from the task of making examples work with 0.9.0 as it likely delay its release.

@tinder-aminghadersohi
Copy link
Contributor

Oh I see, only the examples need to be updated to kotlin dsl. The rest is already that way.

@tinder-aminghadersohi
Copy link
Contributor

I put up.a PR Studyo#1

@garyp
Copy link
Collaborator Author

garyp commented May 9, 2020

Thanks @tinder-aminghadersohi. Can you please open the PR against the streem/pbandk repo so we can get it merged in after the Kotlin/Native PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants