Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Improve error handling when dealing with angular.json files #22663

Merged
merged 1 commit into from
May 22, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 22, 2023

Closes #22350

What I did

The Storybook CLI now throws different errors and requests the user to file an issue to provide us more information. Regarding #22350 so far we found no way to reproduce the issue, so we rely on the community to bring that up to us.

How to test

  1. Get an angular sandbox with no Storybook
  2. Delete all projects on the angular.json file, or make the key contain an empty object, the following error should be thrown:
Error: Storybook was not able to find any projects in your angular.json file. Are you sure this is an Angular CLI project?

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 22, 2023
@yannbf yannbf requested a review from valentinpalkovic May 22, 2023 06:14
@valentinpalkovic valentinpalkovic merged commit fa24eaf into next May 22, 2023
@valentinpalkovic valentinpalkovic deleted the chore/angular-json-issues branch May 22, 2023 07:30
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 22, 2023
shilman pushed a commit that referenced this pull request May 22, 2023
CLI: Improve error handling when dealing with angular.json files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
3 participants