Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Use correct default annotations for composeStories #22308

Merged
merged 1 commit into from
May 8, 2023
Merged

React: Use correct default annotations for composeStories #22308

merged 1 commit into from
May 8, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 28, 2023

Closes #21562

What I did

The default project annotations when using composeStories in a project that did not call setProjectAnnotations could break with errors such as [TypeError: runStep is not a function]. This PR fixes that by calling composeConfigs for the default annotations.

How to test

See the tests!

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf self-assigned this Apr 28, 2023
@yannbf yannbf requested review from kasperpeulen and shilman April 30, 2023 08:38
kasperpeulen
kasperpeulen approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 8, 2023
@yannbf yannbf merged commit 6ce9f84 into next May 8, 2023
@yannbf yannbf deleted the fix/testing-react-default-annotations branch May 8, 2023 13:29
@shilman shilman mentioned this pull request May 9, 2023
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 9, 2023
shilman pushed a commit that referenced this pull request May 9, 2023
@yannbf @shilman
Merge pull request #22308 from storybookjs/fix/testing-react-default-…
ee73c10 
…annotations

React: Use correct default annotations for composeStories
@shilman shilman mentioned this pull request May 9, 2023
Merged
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees

@yannbf yannbf

Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: composeStories from @storybook/react does not work with interactions that use the step function
3 participants
@yannbf @kasperpeulen @shilman