Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Scope styles in sample components from the CLI templates #22162

Merged
merged 8 commits into from
May 9, 2023
Merged

CLI: Scope styles in sample components from the CLI templates #22162

merged 8 commits into from
May 9, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 19, 2023 •
edited
Loading

Closes #19409 , Closes #12423

What I did

Redo of #19433, thank you so so much @Amerlander !

Added storybook specific classes to Page and Header components to prevent its CSS being applied to other elements.

This solution was discussed here before: #19410 (comment)

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Open Storybook in your browser
  3. Access the basic CLI stories, they should not have changed (but their styles would not leak anymore!)

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added bug cli ci:daily Run the CI jobs that normally run in the daily job. labels Apr 19, 2023
@yannbf yannbf force-pushed the fix/scope-sample-styles branch from f93fb35 to ecbcad7 Compare April 19, 2023 10:20
@cdedreuille cdedreuille requested a review from JReinhold April 24, 2023 14:26
JReinhold
JReinhold approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great and simple solution. 🎉

@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 8, 2023
@yannbf yannbf force-pushed the fix/scope-sample-styles branch from 590ba92 to 87e80bc Compare May 9, 2023 06:49
@yannbf yannbf merged commit 97ed646 into next May 9, 2023
@yannbf yannbf deleted the fix/scope-sample-styles branch May 9, 2023 08:20
This was referenced May 9, 2023
Closed
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 9, 2023
shilman pushed a commit that referenced this pull request May 9, 2023
@yannbf @shilman
Merge pull request #22162 from storybookjs/fix/scope-sample-styles
103b4e3 
CLI: Scope styles in sample components from the CLI templates
@shilman shilman mentioned this pull request May 9, 2023
Merged
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

Assignees

@yannbf yannbf

Labels
bug ci:daily Run the CI jobs that normally run in the daily job. cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Svelte Example Components injecting global CSS Storybook styles given higher precedence than project styles
4 participants
@yannbf @JReinhold @shilman @Amerlander