Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix source snippets when parameters.docs.source.type = 'code' #22048

Merged
merged 6 commits into from
Apr 14, 2023
Merged

Docs: Fix source snippets when parameters.docs.source.type = 'code' #22048

merged 6 commits into from
Apr 14, 2023

Conversation

valentinpalkovic
Copy link
Contributor

Closes #21747

What I did

Reverted #21629 and added an E2E test to cover parameters.docs.source.type === 'code' functionality.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic self-assigned this Apr 12, 2023
@valentinpalkovic valentinpalkovic changed the title Valentin/fix csf plugin Docs: Show untranspiled source code when parameters.docs.source.type = 'code' Apr 12, 2023
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 12, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-csf-plugin branch from e9540bc to 6a5c2e5 Compare April 12, 2023 14:02
@valentinpalkovic valentinpalkovic mentioned this pull request Apr 13, 2023
Closed
shilman
shilman approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valentinpalkovic LGTM but tests are failing?

@shilman shilman changed the title Docs: Show untranspiled source code when parameters.docs.source.type = 'code' Docs: Fix source snippets when parameters.docs.source.type = 'code' Apr 14, 2023
@valentinpalkovic
Copy link
Contributor Author

Yes, on it.

@valentinpalkovic valentinpalkovic added the ci:daily Run the CI jobs that normally run in the daily job. label Apr 14, 2023
@valentinpalkovic valentinpalkovic merged commit 6e595f1 into next Apr 14, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/fix-csf-plugin branch April 14, 2023 13:39
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 15, 2023
shilman pushed a commit that referenced this pull request Apr 15, 2023
@valentinpalkovic @shilman
Merge pull request #22048 from storybookjs/valentin/fix-csf-plugin
c87c03e 
Docs: Fix source snippets when parameters.docs.source.type = 'code'
@penicillin0 penicillin0 mentioned this pull request Apr 17, 2023
Merged
@JReinhold JReinhold mentioned this pull request May 9, 2023
Closed
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
bug ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: tsx story's parameters.docs.source.type = 'code' shows compiled js code
3 participants
@valentinpalkovic @shilman @yannbf