Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: no pnp.cjs in the root, regen lockfiles #21908

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Conversation

ndelangen
Copy link
Member

I have received numerous reports of contributors getting mixed up because they ran yarn install in the monorepo root.

That generates a pnp.cjs file, which makes the monorepo not work.

I added back nodeLinker: node_modules to stop this from happening.

I also regenerated the lockfiles

@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Apr 4, 2023
@ndelangen ndelangen self-assigned this Apr 4, 2023
@ndelangen ndelangen requested a review from shilman April 4, 2023 07:37
@ndelangen ndelangen changed the title Norbert/tech-lockfile Build: no pnp.cjs in the root, regen lockfiles Apr 4, 2023
@ndelangen ndelangen changed the title Build: no pnp.cjs in the root, regen lockfiles Build: no pnp.cjs in the root, regen lockfiles Apr 4, 2023
@ndelangen ndelangen requested a review from kasperpeulen April 4, 2023 08:52
@ndelangen
Copy link
Member Author

@shilman self-merging

@ndelangen ndelangen merged commit 6016483 into next Apr 4, 2023
@ndelangen ndelangen deleted the norbert/tech-lockfile branch April 4, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants