-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Fix outdated documentation URLs #29345
Docs: Fix outdated documentation URLs #29345
Conversation
c2bc18e
to
a088fc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
const canBeSetup = control?.disable !== true && row?.type?.name !== 'function'; | ||
return isHovered && canBeSetup ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding a comment explaining the purpose of the 'canBeSetup' check for better code readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flexbox, thank you for putting together this pull request and helping us fix the outdated links in the documentation. We appreciate it 🙏 ! I've checked, and all is good on my end. I'll be more than glad to merge this once the checklist clears.
Have a great day.
Stay safe
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a088fc0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
What I did
I encountered an error on the terminal.
Clinking on the link does not sparks joy.
before
after
I removed the reference of
/react
from the url because for addons we are not using it.Checklist for Contributors
Manual testing
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.Greptile Summary
This pull request updates documentation links across multiple Storybook files by removing the '/react' slug from URLs, improving link consistency and accessibility.
inferArgTypes.ts
andArgControl.tsx
testing-library.ts
to reflect new documentation link format