Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple routing/url system #6

Closed
arunoda opened this issue Mar 29, 2016 · 4 comments
Closed

Add a simple routing/url system #6

arunoda opened this issue Mar 29, 2016 · 4 comments

Comments

@arunoda
Copy link
Member

arunoda commented Mar 29, 2016

Otherwise, after a manual reload we can't get the same story.

@arunoda arunoda changed the title Add a simple routing system Add a simple routing/url system Apr 6, 2016
@lowkay
Copy link

lowkay commented Apr 7, 2016

Howdy,

I've been having a poke around the code and got a working implementation of this feature using react-router.

To get it to work nicely I did a bit of refactoring. I wasn't really initially intending on opening a PR so I changed more than just implementing the feature - such as renaming files to have a jsx extension and naming them CamelCase if they export a type rather than a module.

Anyhow, I plan on raising a PR in the next couple of days and we can discuss the changes. There may be choices that you don't agree with and I'm obviously open to changing things to fit in with the project style/outlook.

Just putting it out there in case somebody else is thinking about this feature.

@arunoda
Copy link
Member Author

arunoda commented Apr 7, 2016

I was also going to re-factor the UI code a bit using the Mantra architecture. But, feel free to send the PR directly.

lowkay pushed a commit to lowkay/react-storybook that referenced this issue Apr 8, 2016
Also rename components to have a jsx extension.
@arunoda
Copy link
Member Author

arunoda commented May 5, 2016

Now this is implemented in the latest release: v1.20.0

@arunoda arunoda closed this as completed May 5, 2016
@arunoda
Copy link
Member Author

arunoda commented Sep 25, 2016

If someone looking for how to use React Router <Links> in Storybook, check this: #485 (comment)

ndelangen pushed a commit that referenced this issue Apr 5, 2017
ndelangen added a commit that referenced this issue Apr 5, 2017
Merge branch 'master' of github.com:storybooks/storybook-ui
ndelangen pushed a commit that referenced this issue Apr 5, 2017
Sort properties alphabetically
ndelangen pushed a commit that referenced this issue Apr 5, 2017
Support circular reference arguments
ndelangen pushed a commit that referenced this issue Apr 11, 2017
ndelangen pushed a commit that referenced this issue Apr 11, 2017
ndelangen pushed a commit that referenced this issue Apr 11, 2017
ndelangen pushed a commit that referenced this issue Apr 11, 2017
Simplified component styles.
ndelangen pushed a commit that referenced this issue Apr 15, 2017
Use a constant key to identify messages
thani-sh pushed a commit that referenced this issue May 24, 2017
igor-dv pushed a commit that referenced this issue Nov 5, 2018
ndelangen pushed a commit that referenced this issue Dec 6, 2019
ghengeveld added a commit that referenced this issue Sep 8, 2021
ndelangen pushed a commit that referenced this issue Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants