-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple routing/url system #6
Comments
Howdy, I've been having a poke around the code and got a working implementation of this feature using react-router. To get it to work nicely I did a bit of refactoring. I wasn't really initially intending on opening a PR so I changed more than just implementing the feature - such as renaming files to have a jsx extension and naming them CamelCase if they export a type rather than a module. Anyhow, I plan on raising a PR in the next couple of days and we can discuss the changes. There may be choices that you don't agree with and I'm obviously open to changing things to fit in with the project style/outlook. Just putting it out there in case somebody else is thinking about this feature. |
I was also going to re-factor the UI code a bit using the Mantra architecture. But, feel free to send the PR directly. |
Also rename components to have a jsx extension.
Now this is implemented in the latest release: |
If someone looking for how to use React Router |
Merge branch 'master' of github.com:storybooks/storybook-ui
Support circular reference arguments
Use a constant key to identify messages
Forwarded exceptions and callback handling
…provider Init Storybook Theme Provider
Otherwise, after a manual reload we can't get the same story.
The text was updated successfully, but these errors were encountered: