-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dist folder from github #309
Comments
Having dist folder in source control allows storybook to be installed from github in addition to npm. See #218. I think its fine if you just submit src changes in your PRs if you like (thanks for those PRs btw :), since we do a new commit for each new version with dist changes. |
Are we recommending to use it from github directly ? In #218 too he tried npm but couldn't get it to work. So we can build the dist just before publishing and remove it after publishing if we are concerned about npm. |
It's not like that. He (or someone) want to use GitHub URL as the source for the package. So, that's why we need to put dist on the GitHub. |
cool then :) |
Anyways
dist
is never supposed to be on github. Its preferable to build files beforepublish
Reasons:
The text was updated successfully, but these errors were encountered: