Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dist folder from github #309

Closed
ritz078 opened this issue Jul 13, 2016 · 5 comments
Closed

Remove dist folder from github #309

ritz078 opened this issue Jul 13, 2016 · 5 comments

Comments

@ritz078
Copy link
Contributor

ritz078 commented Jul 13, 2016

Anyways dist is never supposed to be on github. Its preferable to build files before publish

Reasons:

  • unnecessary clutter in PR
  • irritating conflicts in dist
@roonyh
Copy link
Contributor

roonyh commented Jul 14, 2016

Having dist folder in source control allows storybook to be installed from github in addition to npm. See #218.

I think its fine if you just submit src changes in your PRs if you like (thanks for those PRs btw :), since we do a new commit for each new version with dist changes.

@arunoda
Copy link
Member

arunoda commented Jul 14, 2016

@ritz078 It's the case a @roonyh mentioned.
I am gonna close this.
Just reopen this, if we have a much better solution.

@arunoda arunoda closed this as completed Jul 14, 2016
@ritz078
Copy link
Contributor Author

ritz078 commented Jul 14, 2016

Are we recommending to use it from github directly ? In #218 too he tried npm but couldn't get it to work. So we can build the dist just before publishing and remove it after publishing if we are concerned about npm.

@arunoda
Copy link
Member

arunoda commented Jul 14, 2016

It's not like that. He (or someone) want to use GitHub URL as the source for the package. So, that's why we need to put dist on the GitHub.

@ritz078
Copy link
Contributor Author

ritz078 commented Jul 14, 2016

cool then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants