-
Notifications
You must be signed in to change notification settings - Fork 7
Update @testing-library/jest-dom to v6 #42
Conversation
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @storybook/[email protected], @testing-library/[email protected] |
ce81fe8
to
f4a34c9
Compare
Cool, I tested this out in my pnpm vite project, and I was able to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w/o context, code looks reasonable :p
In order for this to work correctly in vitest, we'll also need storybookjs/expect#77. |
Hey @IanVS thanks a lot for this! I made a canary release of the |
Thanks @yannbf, I tested it out, and it's working beautifully in my pnpm project, without the need to install the jest-dom types or hoist types in my |
That's great! so we can undo the commit where I changed the version of expect, I can do a proper release of expect and we can merge this. Before though, I wonder if you know whether there are any possible breaking changes with the upgrade? |
I don't believe there are any breaking changes here. The breaking changes in jest-dom were the removal of an undocumented api that we don't use ( |
🚀 PR was released in |
This updates to the latest jest-dom, which publishes ESM, removing the need for our previous matcher hack.
Change Type
Indicate the type of change your pull request is:
maintenance
documentation
patch
minor
major
📦 Published PR as canary version:
0.2.2--canary.42.6016476959.0
✨ Test out this PR locally via:
Version
Published prerelease version:
v0.2.2-next.0
Changelog
🐛 Bug Fix
Authors: 2