Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge restart causes dimmers to turn on #9

Closed
stjohnjohnson opened this issue Feb 7, 2016 · 0 comments · Fixed by #12
Closed

Bridge restart causes dimmers to turn on #9

stjohnjohnson opened this issue Feb 7, 2016 · 0 comments · Fixed by #12
Labels
bug

Comments

@stjohnjohnson
Copy link
Owner

Looks like when we restart, we resubscribe to all events. We get the following events back for a dimmer lamp:

  • switch: off
  • level: 50

We then forward both of these to SmartThings. SmartThings ignores the switch off (as the lamp is already off) but sees the level 50 as a "turn on and go to 50%"
stjohnjohnson added a commit that referenced this issue Feb 13, 2016
@stjohnjohnson
Switching default preface to smartthings instead of /smartthings …
c3b6392 
…but leaving backwards compatibility (fixes #10)

Adding saving of history to disk, to prevent startup spam (partial fix for #9)
Do not send level if current state is "off" (fixes #9)
Resubscribe to topics if connection with MQTT is lost (fixes #11)
@stjohnjohnson stjohnjohnson mentioned this issue Feb 13, 2016
Merged
stjohnjohnson added a commit that referenced this issue Feb 13, 2016
@stjohnjohnson
Merge pull request #12 from stjohnjohnson/ForwardsCompatible
b20a518 
Fixing #9, #10, and #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing #9, #10, and #11 stjohnjohnson/smartthings-mqtt-bridge
1 participant
@stjohnjohnson