Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix js message pivot selection (#6813) #8

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

sthagen
Copy link
Owner

@sthagen sthagen commented Feb 27, 2020

  • fix javascript setFieldIgnoringDefault_ logic

  • remove package-lock.json

  • fix build script to include new UT asset file

Co-authored-by: Daniel Kurka [email protected]

* fix javascript setFieldIgnoringDefault_ logic

* remove package-lock.json

* fix build script to include new UT asset file

Co-authored-by: Daniel Kurka <[email protected]>
@sthagen sthagen merged commit f43ed72 into sthagen:master Feb 27, 2020
sthagen pushed a commit that referenced this pull request Oct 9, 2024
…uilder at return.

See godbolt for Android ART compiler: https://godbolt.org/z/M9dWhdqbf

This optimisation brings the implementation  down from 284 bytes to 272 bytes.

- `GeneratedMessage$Builder SingleFieldBuilder.getBuilder() [284 bytes]`
- `GeneratedMessage$Builder SingleFieldBuilder.getBuilder__withLocalVariable() [272 bytes]`

It's not big. It's just a few instructions dropped. These were dropped just before the `ret`:

```
-mov x23, x1
-ldr w0, [x23, #8]
```

And this load dropped before calling `markClean`.
```
-ldr w1, [x23, #8]
```

PiperOrigin-RevId: 683619150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants