Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler flag useOptionals=true turns non-scalar + oneof fields into optional properties #76

Closed
wants to merge 1 commit into from

Conversation

philikon
Copy link
Contributor

Addresses #74

@philikon philikon changed the title Compiler flag useOptionals=true turns non-scalar + oneof fields into optinal properties Compiler flag useOptionals=true turns non-scalar + oneof fields into optional properties May 31, 2020
@philikon
Copy link
Contributor Author

philikon commented Jun 6, 2020

Closing this in favor of a future PR that will have different flags for non-scalar optionals and better oneof typing.

@philikon philikon closed this Jun 6, 2020
@philikon philikon deleted the useOptionals branch June 6, 2020 01:22
zfy0701 pushed a commit to sentioxyz/ts-proto that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant