fix: generate modules for empty files with esModuleInterop #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
reviewed
Jan 26, 2024
| it("generate as external module", () => { | ||
| const generatedPath = path.join(__dirname, "extension.ts"); | ||
| const generatedCode = fs.readFileSync(generatedPath, "utf8"); | ||
| const source = ts.createSourceFile(generatedPath, generatedCode, ts.ScriptTarget.ES2018); |
There was a problem hiding this comment.
I appreciate the test @jk-apple , but I think in this case our "lazy" approach of just checking in the extension.ts file will serve as a good-enough regression + probably resolve the CI error that's failing to find the file to assert against.
If you could push that up, that'd be great; appreciate the fix!
There was a problem hiding this comment.
Thanks for the help, pushed it.
|
Looks great, thanks! |
stephenh
pushed a commit
that referenced
this pull request
Jan 26, 2024
## [1.167.1](v1.167.0...v1.167.1) (2024-01-26) ### Bug Fixes * generate modules for empty files with esModuleInterop ([#992](#992)) ([f0629ab](f0629ab))
|
🎉 This PR is included in version 1.167.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #908.