Type error in field_mask.ts when outputServices=grpc-js and useOptionals=all

[timosaikkonen]

src/generated-grpc-js/google/protobuf/field_mask.ts(258,12): error TS18048: 'message.paths' is possibly 'undefined'.
src/generated-grpc-js/google/protobuf/field_mask.ts(277,5): error TS2322: Type 'string[] | undefined' is not assignable to type 'string[]'.
    Type 'undefined' is not assignable to type 'string[]'.

The interface for FieldMask gets generated as:

export interface FieldMask {
  /** The set of field mask paths. */
  paths?: string[] | undefined
}

And toJSON is missing optional chaining:

  toJSON(message: FieldMask): string {
    return message.paths.join(",")
  }

...and unwrap is returning a string[] | undefined where string[] is expected in the function signature:

  unwrap(message: FieldMask): string[] {
    return message.paths
  }

Looks like this requires a similar treatment as #949. I can give it a go unless I'm missing something?

[stephenh]

Ah yeah, you're diagnosis looks correct; a PR would be great, thanks @timosaikkonen !

[timosaikkonen]

Coming right up.

[stephenh]

🎉 This issue has been resolved in version 1.162.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release
• v1.162.2

Your semantic-release bot 📦🚀