Compilation error when combining useOptionals=all with forceLong=long

[vecerek]

Steps to reproduce

// example.proto

syntax = "proto3";

import "google/protobuf/timestamp.proto";

message Example {
  google.protobuf.Timestamp datetime = 1;
}

and then run:

protoc \
  --plugin=./node_modules/.bin/protoc-gen-ts_proto \
  --ts_proto_opt=useOptionals=all \
  --ts_proto_opt=forceLong=long \
  --ts_proto_out=. \
  example.proto

The generated ts file will have a compilation error in the following function:

function fromTimestamp(t: Timestamp): Date {
  let millis = (t.seconds.toNumber() || 0) * 1_000;
//              ^^^^^^^^^
//              't.seconds' is possibly 'undefined'.ts(18048)
  millis += (t.nanos || 0) / 1_000_000;
  return new globalThis.Date(millis);
}

Expected output

function fromTimestamp(t: Timestamp): Date {
  let millis = (t.seconds?.toNumber() || 0) * 1_000;
  millis += (t.nanos || 0) / 1_000_000;
  return new globalThis.Date(millis);
}

[stephenh]

🎉 This issue has been resolved in version 1.161.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release
• v1.161.1

Your semantic-release bot 📦🚀