feat: add bigint input validation #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input validation for too large int64 and uint64 values when using the compiler option forceLong=bigint.
8de2fdb0
force-pushed
the
feature/add-bigint-validation
branch
from
682c12f to
218ed41
Compare
8de2fdb0
changed the title
8de2fdb0
force-pushed
the
feature/add-bigint-validation
branch
from
91d4cbe to
2fc4459
Compare
|
Looks great @8de2fdb0 , thanks! |
|
Thanks for being so responsive, and I am a bit unsure if that was all, at least it catches all the BigInt types now if If I find any other occurrence of potential number overflows I will make a follow up MR. |
stephenh
pushed a commit
that referenced
this pull request
Oct 5, 2023
# [1.160.0](v1.159.3...v1.160.0) (2023-10-05) ### Features * add bigint input validation ([#938](#938)) ([0f9b6b1](0f9b6b1))
|
🎉 This PR is included in version 1.160.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input validation for too large int64 and uint64 values when using
the compiler option forceLong=bigint.