Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate different MessageType for TypeRegistry when using static-only #863

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix: generate different MessageType for TypeRegistry when using static-only #863

merged 1 commit into from
Jul 5, 2023

Conversation

bouk
Copy link
Collaborator

@bouk bouk commented Jul 5, 2023

Fixes #861

@bouk bouk changed the title fix: generate different MessageType when using static-only fix: generate different MessageType for TypeRegistry when using static-only Jul 5, 2023
stephenh
stephenh approved these changes Jul 5, 2023
View reviewed changes
Copy link
Owner

@stephenh stephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@stephenh stephenh merged commit 477e5f5 into stephenh:main Jul 5, 2023
stephenh pushed a commit that referenced this pull request Jul 5, 2023
@semantic-release-bot
chore(release): 1.151.1 [skip ci]
25aeac2 
## [1.151.1](v1.151.0...v1.151.1) (2023-07-05)

### Bug Fixes

* generate different MessageType when using static-only ([#863](#863)) ([477e5f5](477e5f5)), closes [#861](#861)
@stephenh
Copy link
Owner

stephenh commented Jul 5, 2023

🎉 This PR is included in version 1.151.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenh stephenh stephenh approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combining outputTypeAnnotations=static-only with outputTypeRegistry=true doesn't type check
2 participants
@bouk @stephenh