fix: initialize undefined optional fields upon use #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidzeng0 I've merged your other two PRs, so this one has a conflict now; could you rebase it? Thanks! |
|
Rebased |
|
@davidzeng0 Ah great, thanks for rebasing; can you try and find an existing Just to keep this behavior from regressing. Also, do you think this PR will fix this issue: My guess is yes? Thanks! |
|
As expected, the test fails without 6f6f97d |
|
Great integration test, thank you! |
This was referenced Mar 19, 2023
stephenh
pushed a commit
that referenced
this pull request
Mar 19, 2023
# [1.143.0](v1.142.1...v1.143.0) (2023-03-19) ### Bug Fixes * initialize undefined optional fields upon use ([#802](#802)) ([ee52e06](ee52e06)) ### Features * group encoding and decoding support ([#799](#799)) ([5ebe3c0](5ebe3c0)) ### Performance Improvements * use array.push to prevent reallocation on every field ([#804](#804)) ([a6aea2c](a6aea2c))
|
🎉 This PR is included in version 1.143.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.