Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic upStreamCodes option #618

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

hersentino
Copy link
Contributor

This PR introduces dynamic upStreamCodes option following discussions on #539

@hersentino hersentino changed the title add dynamic upStreamCodes option feat: add dynamic upStreamCodes option Jul 18, 2022
@hersentino hersentino force-pushed the options-retry-code branch from e4e20f1 to 1167c30 Compare July 18, 2022 16:10
Copy link

@doctorpangloss doctorpangloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default upstream codes should be an empty array, it never makes sense for this code to retry. Let the application always decide what to do by default

@stephenh
Copy link
Owner

@hersentino this looks good! Can you run yarn bin2ts to update the generated code in integration/?

@doctorpangloss yeah, I buy that; @hersentino are you fine making a change to also make this default to an empty list? Thanks!

@hersentino
Copy link
Contributor Author

@stephenh all done :)

@stephenh stephenh merged commit 3091023 into stephenh:main Jul 19, 2022
@stephenh
Copy link
Owner

Thanks @hersentino !

stephenh pushed a commit that referenced this pull request Jul 19, 2022
# [1.118.0](v1.117.1...v1.118.0) (2022-07-19)

### Features

* add dynamic upStreamCodes option ([#618](#618)) ([3091023](3091023))
@stephenh
Copy link
Owner

🎉 This PR is included in version 1.118.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants