Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support grpc-web client straming #617

Merged
merged 13 commits into from
Jul 21, 2022
Merged

feat: support grpc-web client straming #617

merged 13 commits into from
Jul 21, 2022

Conversation

luhuaei
Copy link
Contributor

@luhuaei luhuaei commented Jul 14, 2022

Use rxjs support client straming and server straming.

@luhuaei luhuaei changed the title support grpc-web client straming feat: support grpc-web client straming Jul 14, 2022
@snyh snyh mentioned this pull request Jul 15, 2022
Closed
@stephenh
Copy link
Owner

@luhuaei thanks for the PR! I'll take a look today.

My first ask would be, can you try running yarn proto2bin (and not proto2bin:local)?

In theory this should use a docker-hosted protoc that should minimize any local/host-specific version of protoc and mean all of the *.bin file changes in this PR should go away.

Or if that doesn't work, let me know. Thanks!

@luhuaei
Copy link
Contributor Author

luhuaei commented Jul 17, 2022 •
edited
Loading

@luhuaei thanks for the PR! I'll take a look today.

My first ask would be, can you try running yarn proto2bin (and not proto2bin:local)?

In theory this should use a docker-hosted protoc that should minimize any local/host-specific version of protoc and mean all of the *.bin file changes in this PR should go away.

Or if that doesn't work, let me know. Thanks!

Oh, I donot known yarn run build:test will only effect grpc-web relative example .bin files. Thanks for mentiion

Already change 5fa68dc

stephenh
stephenh approved these changes Jul 19, 2022
View reviewed changes
Copy link
Owner

@stephenh stephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @luhuaei , thank you!

@stephenh
Copy link
Owner

@luhuaei looks like there is a small conflict against main b/c we just had another PR land that allows customizing the retry behavior; once that is resolved, I'll merge this in, thanks!

@luhuaei
Copy link
Contributor Author

luhuaei commented Jul 21, 2022

@luhuaei looks like there is a small conflict against main b/c we just had another PR land that allows customizing the retry behavior; once that is resolved, I'll merge this in, thanks!

Thank you! @stephenh

@stephenh stephenh merged commit d3e7f1f into stephenh:main Jul 21, 2022
@stephenh
Copy link
Owner

Just hit merge, and it will auto-release soon; thanks @luhuaei !

stephenh pushed a commit that referenced this pull request Jul 21, 2022
@semantic-release-bot
chore(release): 1.119.0 [skip ci]
9778fa3 
# [1.119.0](v1.118.0...v1.119.0) (2022-07-21)

### Features

* support grpc-web client straming ([#617](#617)) ([d3e7f1f](d3e7f1f))
@stephenh
Copy link
Owner

🎉 This PR is included in version 1.119.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@luhuaei luhuaei mentioned this pull request Jul 28, 2022
Closed
stephenh added a commit that referenced this pull request Jul 28, 2022
@stephenh
Revert "feat: support grpc-web client straming (#617)"
0fa566d 
This reverts commit d3e7f1f.
@stephenh stephenh mentioned this pull request Jul 28, 2022
Merged
stephenh added a commit that referenced this pull request Jul 28, 2022
@stephenh
fix: Revert "feat: support grpc-web client straming (#617)"
0547fa1 
This reverts commit d3e7f1f.
stephenh added a commit that referenced this pull request Jul 28, 2022
@stephenh
fix: Revert "feat: support grpc-web client straming (#617)" (#632)
2f4ecc7 
This reverts commit d3e7f1f.
stephenh pushed a commit that referenced this pull request Jul 28, 2022
@semantic-release-bot
chore(release): 1.121.1 [skip ci]
54257b7 
## [1.121.1](v1.121.0...v1.121.1) (2022-07-28)

### Bug Fixes

* Revert "feat: support grpc-web client straming ([#617](#617))" ([#632](#632)) ([2f4ecc7](2f4ecc7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenh stephenh stephenh approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luhuaei @stephenh