-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Official Buf Plugin #573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing set of instructions @Jake-RoundrockIO , thank you! Going to merge and see what happens!
# [1.114.0](v1.113.0...v1.114.0) (2022-05-27) ### Features * Official Buf Plugin ([#573](#573)) ([e6272c4](e6272c4))
🎉 This PR is included in version 1.114.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The tag triggered by the |
Hey @Jake-RoundrockIO , I'm thinking it's because of this: I.e. the way ts-proto is using semantic-release out-of-the-box, their scripts are creating a net-new commit with the changelog and tagging that one, but with a "skip ci" in it... So, dunno, kinda looks like the Buf workflow will basically have to run on the pre-tagged commit, so on like pushes to
...but then also either a) run as part of the existing main build to get the semantic-release determined version number, b) run in parallel to the main build and also invoke semantic-release but solely to determine the version number, c) ...something else? |
I think option |
@Jake-RoundrockIO okay! It took a few tries but looks like it worked: Thanks! |
You're amazing! Thanks for the help getting this worked out! |
Per Buf's website:
The goal of this PR is to support further adoption of the Buf ecosystem of tooling by making this library available through the BSR Plugin system.
This will allow library users greater flexibility when utilizing
ts-proto
as it allows them:node_module
size.ts-proto
and a user's.proto
files that can be used to standardize proto generation accross a project and/or team.To meet this end, this PR introduces a new GitHub Actions workflow that, on tagged release, builds and pushes the latest version of
ts-proto
to the BSR Plugin registry.In addition to the changes made in this PR, @stephenh it is necessary that you create an account with buf.build (I have checked and
stephenh
is available at the time of submission 😊) and perform the following steps.Create Plugin
buttonts-proto
Public
BUF_USERNAME
andBUF_PASSWORD
in this repository's settings tab and set them equal to your account name (presumablystephenh
) and your API token, respectively.With these steps completed, GitHub Actions should be able to automatically push to the BSR Plugin registry on tagged release.
Relates to issue #569