-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: First class support for nice-grpc #545
Labels
Comments
aikoven
pushed a commit
to aikoven/ts-proto
that referenced
this issue
Apr 24, 2022
stephenh
pushed a commit
that referenced
this issue
May 1, 2022
…555) Closes #545 Co-authored-by: aikoven <[email protected]>
🎉 This issue has been resolved in version 1.112.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I've been able to move over to using the generates interfaces in our project and IntelliJ does indeed like them a lot more, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ts-proto currently has the "generic" service output target that creates a data representation of a service that can be used both at runtime, and to infer Typescript type signatures of services and clients.
With the magic of Typescript, this works with respect to type checking. An implementation of a service in nice-grpc that implements
ServiceImplementation<typeof SomeServiceDefinition>
will be appropriately typed and any mismatch in signature will be flagged.It is not however that IDE friently. Specifically due to the inferred type signatures, there's no clean way to simply use "implement interface" or similar refactoring tools in IntelliJ or other IDEs. It is possible, but the signature it generates is far from readable.
To support nice-grpc, it would be extremely helpful if a regular Typescript interface could be generated, matching the signature of ServiceImplementation and extending from it, so that an implementing class could simply provide the methods of this regular interface and typing errors would be much more readable.
The text was updated successfully, but these errors were encountered: