feat: implemented emitImportedFiles flag #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes stephenh#294. This commit puts changes from stephenh#283 behind the flag.
stephenh
approved these changes
May 22, 2021
| const files = await Promise.all( | ||
| protoFilesToGenerate(request).map(async (file) => { | ||
| filesToGenerate.map(async (file) => { |
There was a problem hiding this comment.
Nice!
I've been bitten by this before, but can you update integration/codegen.ts as well? Either with the same logic you have here, or maybe just have it always use request.protoFile? I don't think we have an integration test that explicitly tests that protoFilesToGenerate codepath, which is fine I think...
There was a problem hiding this comment.
HI!
I've updated codegen.ts. I think usage of request.protoFile should be enough fo tests.
stephenh
pushed a commit
that referenced
this pull request
May 23, 2021
|
🎉 This PR is included in version 1.81.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294.
This commit puts changes from #283 behind the flag.