google.protobuf.Value NullValue is replaced by undefined in fromPartial method of parent message

[simonenkoav]

We have proto message Parent like this:

message Parent {
    string name = 1;
    google.protobuf.Value value = 2;
}

and ts-proto generates this:

export interface Parent {
  name: string;
  value: any | undefined;
}

When request is sent to the server fromPartial method is called, I guess generation for this is here:

ts-proto/src/generate-grpc-web.ts

Line 78 in 37d3a39

${requestMessage}.fromPartial(request),

which looks like this:

fromPartial<I extends Exact<DeepPartial<Parent>, I>>(object: I): Parent {
    const message = createBaseParent();
    message.name = object.name ?? "";
    message.value = object.value ?? undefined;  // <--- here
    return message;
}

so value=null is replaced by undefined (I guess because of this line

ts-proto/src/main.ts

Line 2646 in 37d3a39

return code`${from}`;

), so when encoding in Parent.encode:

encode(message: Parent, writer: BinaryWriter = new BinaryWriter()): BinaryWriter {
    if (message.name !== "") {
      writer.uint32(10).string(message.name);
    }
    if (message.value !== undefined) {
      Value.encode(Value.wrap(message.value), writer.uint32(18).fork()).join();  // <--- here
    }
    return writer;
}

null value is not wrapped, so server receives null instead of NullValue.

Could you please support correct handling of null values in fromPartial?

[stephenh]

Hi @simonenkoav , thanks for filing the issue!

Honestly it sounds like you've done a great job of dissecting what is going wrong--if you could turn those insights into a PR that fixes the issue, that would be amazing!

Sorry for the late reply, and the ask for a PR, but that's just realistically how ts-proto keeps evolving/getting better, is our users turning into contributors (even if it's only for one-time PRs) and slowly helping it get better and better. Thanks!