Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefix and suffixes were not being applied to to/fromTimestamp resulting in compile error #1118

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Oct 4, 2024

No description provided.

@halkeye
Copy link
Contributor Author

halkeye commented Oct 4, 2024

btw, would love if you threw a hacktoberfest label on the project or pr. Gotta get that bragging rights every year.

@halkeye halkeye force-pushed the timestamps-prefix-suffix branch from 04dfed6 to 3933211 Compare October 4, 2024 02:13
Copy link
Owner

@stephenh stephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @halkeye !

@stephenh stephenh merged commit 22c2905 into stephenh:main Oct 4, 2024
6 checks passed
stephenh pushed a commit that referenced this pull request Oct 4, 2024
## [2.2.2](v2.2.1...v2.2.2) (2024-10-04)

### Bug Fixes

* prefix and suffixes were not being applied to to/fromTimestamp resulting in compile error ([#1118](#1118)) ([22c2905](22c2905))
@stephenh
Copy link
Owner

stephenh commented Oct 4, 2024

🎉 This issue has been resolved in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@halkeye
Copy link
Contributor Author

halkeye commented Oct 4, 2024

I love semantic release. This is the first time I've been on the other side of it. I love it comments on pr.

Can you change the label to hacktoberfest-accepted?

@stephenh
Copy link
Owner

stephenh commented Oct 6, 2024

@halkeye yep, added the hackoberfast-accepted label to this and your other PR; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants