Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating into EAK #473

Closed
seifsallam opened this issue Feb 6, 2014 · 16 comments
Closed

Migrating into EAK #473

seifsallam opened this issue Feb 6, 2014 · 16 comments

Comments

@seifsallam
Copy link
Contributor

I just moved from yo-ember to EAK and I've here are some of the problems that I had

  1. Every export should be in its own file. I used to have the main route with sub routes like PostRoute and PostCommentsRoute in the same file, but this didn't work in EAK, i had to extract each one into its own place.
  2. Nested needs should be called via / no .. This error exists in the EAK, but not in the docs. Also it wasn't clear that i had to change it too in the getter @get 'controllers.post/comments.content'
  3. ember-auth is not compatible. I'm thinking maybe have a section that talks about incompatible packages.
  4. For using scss, in your styles it should be app.scss but in your index file it should app.css. As for importing non-scss you should add those packages to your index file before app.css (I used to import them by converting .css to .scss ext using grunt)
  5. For coffeescript to work, you need to add ` symbol to export and import
`import AutoSave from 'appkit/mixins/auto_save'`
`export default PostsController`

I would love to add these stuff to the EAK docs, and it would be awesome to get some feedback here on which should go in the docs and and what not

@potomak
Copy link
Contributor

potomak commented Feb 6, 2014

Every export should be in its own file.

There's note of that in Using Modules & the Resolver where the docs say: Only the default export is supported, at the moment.

ember-auth is not compatible.

I'm using ember-auth with EAK apparently without problems.

@seifsallam
Copy link
Contributor Author

There's note of that in Using Modules & the Resolver where the docs say: Only the default export is supported, at the moment.

Yes, but I was doing multiple export in the same file. I'm new to ES6, and i thought if i just did export it would just work. To be honest i didn't understand that default means the current file

export default PostController
export default PostCommentsController

I'm using ember-auth with EAK apparently without problems.

Did you do any modifications on it? Because when i tried to get it to work, i got a lot of errors from module-ember-data, module-action-redirect and module-auth-redirectable.

@shadow-fox
Copy link
Contributor

@potomak Would you like to open source the ember-auth bit ?

@potomak
Copy link
Contributor

potomak commented Feb 6, 2014

@seifsallam @shadow-fox I'm using ember-auth 8.0.1 with emberModel, rememberable, authRedirectable, actionRedirectable.

@seifsallam
Copy link
Contributor Author

Isn't 8.0 a bit outdated. I still think it would be helpful to have a section for mentioning that. Maybe "v9.0 is incompatible with EAK, and if you still want to use it you'll need to downgrade to v8.0"

@stefanpenner
Copy link
Owner

Currently we don't have plans to support resolving non default exports

@stefanpenner
Copy link
Owner

  1. Isn't an error but expected behavior. If it is indeed missing from the docs I would appreciate a pull request that adds it to the docs

@stefanpenner
Copy link
Owner

@stefanpenner
Copy link
Owner

  1. Is an unfortunate limitation of coffee script. Hopefully they will solve this issue soon, I would suggest opening an issue on coffeescript (unless one already exists)

Thanks for your feedback

@seifsallam
Copy link
Contributor Author

@stefanpenner Yeah, its cool, default is good. But I'm just saying in my case i didn't know what default meant, and just added multiple export in the same file.

Isn't an error but expected behavior. If it is indeed missing from the docs I would appreciate a pull request that adds it to the docs

I'm not following. All the numbers in the comments are 1

Is in the docs see: http://iamstef.net/ember-app-kit/guides/naming-conventions.html

Bad luck :D, It was just added later yesterday, i didn't notice it

@stefanpenner
Copy link
Owner

Maybe docs should be added to explain resolving only works with export default

@stefanpenner
Copy link
Owner

Ha at the numbers all being one. My mobile client shows them correctly, but it appears the web client does indeed show only 1. I'll fix when I'm on a desktop

@seifsallam
Copy link
Contributor Author

so

  1. Pull request
  2. Done
  3. What about ember-auth, can we add a section for incompatibility maybe?. I know this is outside EAK scope
  4. Should I add add the docs for that? Maybe i can copy the docs on that section from the wiki
  5. CoffeeScript issue, but in the meantime should there be a note?

@stefanpenner
Copy link
Owner

What about ember-auth, can we add a section for incompatibility maybe?.

people seem to be using this successfully, I have not personally used it so I am unsure. Maybe I need to carve out some time and see what the pain points are. Also related, @rjackson and me have a plan that should drastically improve plugin/addon interop. So maybe investigating the issues with ember-auth will yield some additional constraints

Should I add add the docs for that? Maybe i can copy the docs on that section from the wiki

Sure, I would actually like to deprecate the wiki entirely, and keep the webpage the single source of truth for documentation. If you have some extra time, help here would be appreciated.

CoffeeScript issue, but in the meantime should there be a note?

a note sounds good, you should also make sure an issue is open on coffee-script, feel free to CC me on it.

@WMeldon
Copy link

WMeldon commented Feb 6, 2014

There is already an issue filed for the CoffeeScript thing jashkenas/coffeescript#3162. Not the best news unfortunately, but hopefully it'll catch up.

In regards to the non-default exports, I understand that the resolver really isn't going to be able to handle that, but does that mean you can't use them for things you manually resolve? I tried to import a non-default utility class a while back and it only ever gave me the default.

I couldn't tell if it was EAK or just me being wrong. Modules worked fine, importing a named didn't. I just assumed the docs meant 'No named exports PERIOD'.

@seifsallam
Copy link
Contributor Author

@stefanpenner I've opened a pull request that solves the CS issue, and moves the good parts of the wiki #474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants