-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating into EAK #473
Comments
There's note of that in Using Modules & the Resolver where the docs say: Only the
I'm using |
Yes, but I was doing multiple export in the same file. I'm new to ES6, and i thought if i just did export it would just work. To be honest i didn't understand that default means the current file
Did you do any modifications on it? Because when i tried to get it to work, i got a lot of errors from |
@potomak Would you like to open source the ember-auth bit ? |
@seifsallam @shadow-fox I'm using ember-auth 8.0.1 with |
Isn't 8.0 a bit outdated. I still think it would be helpful to have a section for mentioning that. Maybe "v9.0 is incompatible with EAK, and if you still want to use it you'll need to downgrade to v8.0" |
Currently we don't have plans to support resolving non default exports |
|
|
Thanks for your feedback |
@stefanpenner Yeah, its cool, default is good. But I'm just saying in my case i didn't know what default meant, and just added multiple export in the same file.
I'm not following. All the numbers in the comments are 1
Bad luck :D, It was just added later yesterday, i didn't notice it |
Maybe docs should be added to explain resolving only works with export default |
Ha at the numbers all being one. My mobile client shows them correctly, but it appears the web client does indeed show only 1. I'll fix when I'm on a desktop |
so
|
people seem to be using this successfully, I have not personally used it so I am unsure. Maybe I need to carve out some time and see what the pain points are. Also related, @rjackson and me have a plan that should drastically improve plugin/addon interop. So maybe investigating the issues with ember-auth will yield some additional constraints
Sure, I would actually like to deprecate the wiki entirely, and keep the webpage the single source of truth for documentation. If you have some extra time, help here would be appreciated.
a note sounds good, you should also make sure an issue is open on coffee-script, feel free to CC me on it. |
There is already an issue filed for the CoffeeScript thing jashkenas/coffeescript#3162. Not the best news unfortunately, but hopefully it'll catch up. In regards to the non-default exports, I understand that the resolver really isn't going to be able to handle that, but does that mean you can't use them for things you manually resolve? I tried to import a non-default utility class a while back and it only ever gave me the default. I couldn't tell if it was EAK or just me being wrong. Modules worked fine, importing a named didn't. I just assumed the docs meant 'No named exports PERIOD'. |
@stefanpenner I've opened a pull request that solves the CS issue, and moves the good parts of the wiki #474 |
I just moved from
yo-ember
to EAK and I've here are some of the problems that I hadPostRoute
andPostCommentsRoute
in the same file, but this didn't work in EAK, i had to extract each one into its own place.needs
should be called via/
no.
. This error exists in the EAK, but not in the docs. Also it wasn't clear that i had to change it too in the getter@get 'controllers.post/comments.content'
ember-auth
is not compatible. I'm thinking maybe have a section that talks about incompatible packages.app.scss
but in your index file it shouldapp.css
. As for importing non-scss you should add those packages to your index file beforeapp.css
(I used to import them by converting .css to .scss ext using grunt)I would love to add these stuff to the EAK docs, and it would be awesome to get some feedback here on which should go in the docs and and what not
The text was updated successfully, but these errors were encountered: