Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat_: LogOnPanic linter #5969

Merged
merged 6 commits into from
Oct 23, 2024

fix_: address pr comments

cc809f9
Select commit
Loading
Failed to load commit list.
Merged

feat_: LogOnPanic linter #5969

fix_: address pr comments
cc809f9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 23, 2024 in 0s

47.69% (+0.04%) compared to 8dc70e9

View this Pull Request on Codecov

47.69% (+0.04%) compared to 8dc70e9

Details

Codecov Report

Attention: Patch coverage is 63.07692% with 120 lines in your changes missing coverage. Please review.

Project coverage is 47.69%. Comparing base (8dc70e9) to head (cc809f9).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
cmd/lint-panics/gopls/gopls.go 54.21% 31 Missing and 7 partials ⚠️
cmd/lint-panics/gopls/dummy_client.go 21.95% 31 Missing and 1 partial ⚠️
cmd/lint-panics/analyzer/analyzer.go 78.94% 18 Missing and 10 partials ⚠️
cmd/lint-panics/analyzer/config.go 60.00% 5 Missing and 5 partials ⚠️
cmd/lint-panics/gopls/stream.go 40.00% 6 Missing ⚠️
cmd/lint-panics/utils/utils.go 83.33% 2 Missing and 1 partial ⚠️
protocol/messenger.go 0.00% 2 Missing ⚠️
metrics/metrics.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5969      +/-   ##
===========================================
+ Coverage    47.64%   47.69%   +0.04%     
===========================================
  Files          843      849       +6     
  Lines       138244   138576     +332     
===========================================
+ Hits         65873    66089     +216     
- Misses       64608    64696      +88     
- Partials      7763     7791      +28     
Files with missing lines Coverage Δ
healthmanager/blockchain_health_manager.go 94.82% <100.00%> (+1.78%) ⬆️
protocol/encryption/publisher/publisher.go 72.88% <100.00%> (+0.46%) ⬆️
protocol/messenger_store_node_request_manager.go 40.95% <100.00%> (+0.21%) ⬆️
rpc/client.go 65.74% <100.00%> (+0.15%) ⬆️
services/wallet/api.go 37.60% <100.00%> (+0.30%) ⬆️
services/wallet/balance/ttl_cache.go 95.55% <100.00%> (+0.31%) ⬆️
services/wallet/common/mock/feed_subscription.go 90.47% <100.00%> (+0.47%) ⬆️
waku/v1/peer.go 58.00% <ø> (-0.42%) ⬇️
wakuv2/waku.go 70.21% <ø> (+0.24%) ⬆️
metrics/metrics.go 0.00% <0.00%> (ø)
... and 7 more

... and 31 files with indirect coverage changes