You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
In the
virtualfund
protocol we swallow certain errors:go-nitro/protocols/virtualfund/virtualfund.go
Lines 86 to 88 in cd34325
(and similarly for the
virtualdefund
protocol).I think it would be nice to log this error out at least. To do that, we could bubble it up to the engine, which has access to the logger.
Could have a principle that the engine is the only place (or at least the default place) where errors are swallowed?
Beta Was this translation helpful? Give feedback.
All reactions