Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.8.0 broken on illumos #371

Closed
citrus-it opened this issue Mar 15, 2024 · 2 comments · Fixed by #373
Closed

3.8.0 broken on illumos #371

citrus-it opened this issue Mar 15, 2024 · 2 comments · Fixed by #373

Comments

@citrus-it
Copy link
Contributor

As of version 3.8.0, this crate fails to compile on illumos:

error[E0308]: mismatched types
  --> /home/af/.cargo/registry/src/index.crates.io-6f17d22bba15001f/os_info-3.8.0/src/illumos/mod.rs:32:14
   |
31 |     match uname("-o") {
   |           ----------- this expression has type `std::option::Option<std::string::String>`
32 |         Some("illumos") => Type::Illumos,
   |              ^^^^^^^^^ expected `String`, found `&str`
@sunshowers
Copy link

Can os_info use nix or libc's uname support? https://docs.rs/nix/0.28.0/nix/sys/utsname/fn.uname.html

@stanislav-tkach
Copy link
Owner

@sunshowers I think it is a good idea, but I prefer to experiment with it later and quickly fix current issues with a simple patch. I have created an issue (#375) to return to this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants