Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More configurable span tracing categories #10

Open
nagisa opened this issue Oct 26, 2022 · 0 comments
Open

More configurable span tracing categories #10

nagisa opened this issue Oct 26, 2022 · 0 comments

Comments

@nagisa
Copy link
Collaborator

nagisa commented Oct 26, 2022

Today this library registers a single tracer which in turn unconditionally registers all the hooks it is interested at once:

self.register_hook(TracerHook::PadPushPost);
self.register_hook(TracerHook::PadPushPre);
self.register_hook(TracerHook::PadPushListPost);
self.register_hook(TracerHook::PadPushListPre);
self.register_hook(TracerHook::PadQueryPost);
self.register_hook(TracerHook::PadQueryPre);
self.register_hook(TracerHook::PadPushEventPost);
self.register_hook(TracerHook::PadPushEventPre);
self.register_hook(TracerHook::PadPullRangePost);
self.register_hook(TracerHook::PadPullRangePre);

If we wanted to extend the scope of the tracing this library does (which I would very much like to,) we sort-of need to figure out a way to make the trace interest more configurable. One option would be to actually have different Tracer objects for each different trace categories. We could alternatively expose the Tracer as a public API and handle the registration of different events outside of the object creation, giving users granular control to do the same for themselves.


If nothing else, this gives a great way for people to mitigate locally issues that might occur as a result of bug in bindings or this library in tracers for a specific event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant