Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sst++ does not pass flags correctly #709

Open
burlen opened this issue Dec 14, 2023 · 1 comment
Open

sst++ does not pass flags correctly #709

burlen opened this issue Dec 14, 2023 · 1 comment
Assignees

Comments

@burlen
Copy link

burlen commented Dec 14, 2023

sst++ in a standalone build of v13.1.0_Final of does not pass flags such as -DFOO through.

to reproduce:

test.cc

#if defined(FOO)
foo // this should error out
#else
int foo(int f) { return f + 1; };
#endif

This code should not compile if -DFOO is passed to the compiler. for example using g++

 g++ test.cc -c  -DFOO
test.cc:2:1: error: 'foo' does not name a type
    2 | foo // this should error out
      | ^~~

This is the expected and correct result. However, with sst++ the define is not propagated

sst++ test.cc -c  -DFOO

a .o file is produced, but this command should fail to compile.

@shady831213
Copy link

shady831213 commented Sep 25, 2024

https://github.com/sstsimulator/sst-macro/blob/master/bin/sstcompile.py#L246
Missing args.D collection
The following line shoud be added:

ppArgs.extend(map(lambda x: "-D%s" % x, args.D))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants