Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two different predict_risk implementations #49

Open
iamyihwa opened this issue Feb 8, 2022 · 0 comments
Open

two different predict_risk implementations #49

iamyihwa opened this issue Feb 8, 2022 · 0 comments

Comments

@iamyihwa
Copy link

iamyihwa commented Feb 8, 2022

For others such as predict_survival, predict_hazard, predict_cdf, implementation in models.py are used in Simulations.

However for predict_risk, in Simulations, instead of using the one in models.py , it uses the one in simulations.py

The two predict_risk ( models.py, simulations.py ), give quite different result.

The one from models.py being sum over cumulative hazard, whereas the one in simulations.py being a sum over weight values (or more complex forms depending on the choice.)

Wonder why it is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant