Move NSData to ByteString conversion onto ByteString companion
#1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a convenience for Objeective-C/Swift callers such that when a ByteString is exposed in your header you are also given this (and any future) conversion functions as automatically available. Because SegmentedByteString relies on ByteString's internal constructor which is only avaialble in the actuals it must be duplicated in the two source sets.
oldergod
approved these changes
Jul 12, 2022
JakeWharton
commented
Jul 12, 2022
| @@ -1,39 +1,221 @@ | |||
| /* | |||
| * Copyright (C) 2020 Square, Inc. | |||
| * Copyright (C) 2018 Square, Inc. | |||
There was a problem hiding this comment.
This old file was deleted, the other file moved here with the same name, and the extension hand written at the bottom. It is not actually changed but git thinks it's being smart.
swankjesse
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a convenience for Objeective-C/Swift callers such that when a
ByteStringis exposed in your header you are also given this (and any future) conversion functions as automatically available.Because
SegmentedByteStringrelies onByteString's internal constructor which is only avaialble in the actuals it must be duplicated in the two source sets.Closes #1113