Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PR: Provide an API for external plugins to load/save/create new files #8798

Closed
wants to merge 9 commits into from

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Feb 18, 2019

This PR provides a public API for external plugins to register their own functionality when the following buttons/actions are pressed in Spyder toolbar and its File menu:

  • New file
  • Load file
  • Save file
  • Save all
  • Save as
  • Recent files

Fixes #7794.

Temporal TODOs (just so I don't forget to address them):

  • Save button is disabled when a file in the Editor is saved. It should be enabled/disabled in a per plugin basis.
  • Rename PluginWidget to BasePluginWidget (update changelog about that).
  • Add comments explaining what the signals in BasePluginWidget do.

@ccordoba12 ccordoba12 added this to the v4.0beta3 milestone Feb 18, 2019
spyder/api/plugins.py Outdated Show resolved Hide resolved
@pep8speaks
Copy link

pep8speaks commented Feb 27, 2019

Hello @ccordoba12! Thanks for updating the PR.

Line 81:1: E402 module level import not at top of file
Line 159:1: E402 module level import not at top of file

Line 914:17: E127 continuation line over-indented for visual indent

Comment last updated on March 02, 2019 at 14:48 Hours UTC

It's shortcut needs to be global now since it can be used both by the
Editor and third-party plugins.
…utton

Also declare that the Editor is able to save files.
@ccordoba12 ccordoba12 changed the title [WIP] PR: Provide an API for external plugins to register file extensions they can open [WIP] PR: Provide an API for external plugins to load/save/create new files Mar 2, 2019
@ccordoba12 ccordoba12 modified the milestones: v4.0beta3, v4.0beta4 May 18, 2019
@goanpeca goanpeca mentioned this pull request Jun 8, 2019
14 tasks
@ccordoba12 ccordoba12 modified the milestones: v4.0betaX, v4.0beta4 Jun 17, 2019
@ccordoba12 ccordoba12 modified the milestones: v4.0beta4, v4.0beta5 Jul 15, 2019
@ccordoba12 ccordoba12 modified the milestones: v4.0beta5, v4.0betaX Aug 31, 2019
@ccordoba12 ccordoba12 modified the milestones: v4.0rc, future Sep 17, 2019
@goanpeca goanpeca removed this from the future milestone Feb 23, 2020
@jitseniesen
Copy link
Member

@ccordoba12 What's the plan with this? How about I take over?

My intention is to do some more work on spyder-notebook as it seems there is quite some interest in it.

@ccordoba12
Copy link
Member Author

Closing because this was superseded by #22564.

@ccordoba12 ccordoba12 closed this Sep 25, 2024
@ccordoba12 ccordoba12 deleted the issue-7794 branch September 25, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow plugins to hook into File > Open
5 participants