Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize inter-thread context propagation #23876

Closed
ashamukov opened this issue Oct 28, 2019 · 1 comment
Closed

Generalize inter-thread context propagation #23876

ashamukov opened this issue Oct 28, 2019 · 1 comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another

Comments

@ashamukov
Copy link

Hello!

While working on asynchronous retry support in spring-retry, we encountered a scenario, where some thread-fixed context should be propagated from a scheduler thread (that calls executor.execute(...)) to the worker thread (that actually executes the runnable).

We found the same pattern implemented in org.springframework.security.concurrent package of spring-security for SecurityContext: https://github.com/spring-projects/spring-security/tree/master/core/src/main/java/org/springframework/security/concurrent

The idea of the issue is to generalize this mechanics: extract common part to spring-core and use it for SecurityContext in spring-security, and for RetryContext in spring-retry.

Here is a prototype of an implementation: ashamukov/spring-security#1
What do you think?

Thanks

cc: @rwinch

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 28, 2019
@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Nov 10, 2021
@bclozel
Copy link
Member

bclozel commented Nov 20, 2023

Sorry it took us so long to reply to this issue.
I think that in the meantime, this has been implemented by the context-propagation project. We are already using this in Spring Framework and various Spring projects. I'm closing this issue as superseded.

Thanks!

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
@bclozel bclozel added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another
Projects
None yet
Development

No branches or pull requests

4 participants