Update ContainerProperties to match k8s PodSpec. #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated tests to use old and new names. Deprecated old names. Fixes spring-cloud#477
Wordbe
reviewed
Sep 24, 2024
| .withEnv(envVars) | ||
| .withEnvFrom(envFromSources) | ||
| .withArgs(appArgs) | ||
| .withImagePullPolicy(deploymentPropertiesResolver.getImagePullPolicy(deploymentProperties)) |
| @@ -1327,7 +1327,7 @@ public void initContainerFromGlobalProps() { | |||
| // Set up a global initContainer (it should be chosen) | |||
| KubernetesDeployerProperties.InitContainer globalInitContainerProps = new KubernetesDeployerProperties.InitContainer(); | |||
| globalInitContainerProps.setContainerName("test-global"); | |||
| globalInitContainerProps.setImageName("busybox:latest"); | |||
| globalInitContainerProps.setImage("busybox:latest"); | |||
| @@ -1327,7 +1327,7 @@ public void initContainerFromGlobalProps() { | |||
| // Set up a global initContainer (it should be chosen) | |||
| KubernetesDeployerProperties.InitContainer globalInitContainerProps = new KubernetesDeployerProperties.InitContainer(); | |||
| globalInitContainerProps.setContainerName("test-global"); | |||
There was a problem hiding this comment.
it would be better to use 'name' instead of 'containerName'
Wordbe
reviewed
Sep 24, 2024
| List<String> commands = StringUtils.hasText(commandStr) ? Arrays.asList(commandStr.split(",")) : Collections.emptyList(); | ||
| String argsStr = PropertyParserUtils.getDeploymentPropertyValue(kubeProps, propertyKey, ".args"); | ||
| List<String> args = StringUtils.hasText(argsStr) ? Arrays.asList(argsStr.split(",")) : Collections.emptyList(); | ||
| String envString = PropertyParserUtils.getDeploymentPropertyValue(kubeProps, propertyKey + "environmentVariables"); |
There was a problem hiding this comment.
Would it be difficult to use 'env' instead of 'environmentVariables'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tests to use old and new names.
Deprecated old names.
Fixes #477