Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Launcher doesn't create Job as expected. #448

Open
corneil opened this issue Apr 12, 2024 · 2 comments
Open

Task Launcher doesn't create Job as expected. #448

corneil opened this issue Apr 12, 2024 · 2 comments
Labels
type/enhancement Is an enhancement request
Milestone

Comments

@corneil
Copy link
Contributor

corneil commented Apr 12, 2024

Description:
Deploying a Task with CTR definition and launching as a job with ttl-seconds-after-finished doesn't apply the properties as expected. No Kubernetes Job is created.
When the task is Scheduled then we do find that Jobs are created according to the schedule. However the ttlSecondsAfterFinished does not appear in the description of the Job.

Steps to reproduce
Create a task with dsl timestamp && timestamp-batch
Launch with the properties:

deployer.*.kubernetes.create-job=true
deployer.*.kubernetes.ttl-seconds-after-finished=120

Release versions:
2.11.2

@cppwfs
Copy link
Contributor

cppwfs commented Apr 17, 2024

SCDF currently sets this property globally for all apps spring.cloud.deployer.kubernetes.createJob. However, the deployer can be updated so that it can check for the deployer.kubernetes.create-job property and if present it will create the job (or not) based on the boolean value.

@cppwfs cppwfs transferred this issue from spring-cloud/spring-cloud-dataflow Apr 17, 2024
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Apr 17, 2024
@cppwfs
Copy link
Contributor

cppwfs commented Apr 22, 2024

After further investigation, in order for SCDF to support the ability for a user to specify spring.cloud.deployer.kubernetes.create-job true or false for each task launch, we'd have to update SCDF to check both jobs and pods for deletions, log acquisition, creation(launching), retrieving task resources etc. You can view some of the changes required here: https://github.com/cppwfs/spring-cloud-deployer/tree/DEP-JOB-TASK

@cppwfs cppwfs added type/feature and removed status/need-triage Team needs to triage and take a first look labels Apr 22, 2024
@cppwfs cppwfs added this to the 3.0.x milestone Apr 22, 2024
@cppwfs cppwfs added type/enhancement Is an enhancement request and removed type/feature labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Is an enhancement request
Projects
None yet
Development

No branches or pull requests

2 participants