Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deploymentLabels as a deployer property #344

Closed
ilayaperumalg opened this issue Nov 27, 2019 · 2 comments
Closed

Add deploymentLabels as a deployer property #344

ilayaperumalg opened this issue Nov 27, 2019 · 2 comments

Comments

@ilayaperumalg
Copy link
Contributor

As part of #248, the spring.cloud.deployer.kubernetes.deploymentLabels property is checked by the K8s app deployer for additional labels. But, this specific property wasn't added into K8s deployer properties.
@chrisjs
Copy link
Contributor

chrisjs commented Nov 27, 2019

“wasn’t added into k8s deployer properties” as in meaning exposed as a global property or something else? global/per app is considered on a per property basis

@onobc
Copy link
Contributor

onobc commented Dec 5, 2024

This was completed in spring-cloud/spring-cloud-deployer@52bd1ee#diff-cbc0099be796a4520bb4e90ca1f3f2f60d69fe6dff36eb3df19805eb1ccaaabdR616

@onobc onobc closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ilayaperumalg @chrisjs @onobc