Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove competing auto-config #197

Open
jvalkeal opened this issue Mar 13, 2018 · 2 comments
Open

Remove competing auto-config #197

jvalkeal opened this issue Mar 13, 2018 · 2 comments
Assignees
Labels
type/technical-debt Techical Dept

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Mar 13, 2018

Looks like we try to autoconfigure KubernetesClient which also happens in fabric8.

@Bean
public KubernetesClient kubernetesClient() {
return new DefaultKubernetesClient().inNamespace(properties.getNamespace());

https://github.com/fabric8io/spring-cloud-kubernetes/blob/6f3ae54598698e8595fa5d0ad8349ad4bea8cdfb/spring-cloud-kubernetes-core/src/main/java/io/fabric8/spring/cloud/kubernetes/KubernetesAutoConfiguration.java#L75-L78

@chrisjs
Copy link
Contributor

chrisjs commented Jun 8, 2018

@jvalkeal
Copy link
Contributor Author

jvalkeal commented Jun 8, 2018

It is, KubernetesClient is still auto-configured and created from two different places, us and fabric8. Using @AutoConfigureOrder(Ordered.HIGHEST_PRECEDENCE) is kinda hack around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/technical-debt Techical Dept
Projects
None yet
Development

No branches or pull requests

3 participants