Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Arrays expose child names #1671

Open
a10y opened this issue Dec 12, 2024 · 4 comments
Open

Have Arrays expose child names #1671

a10y opened this issue Dec 12, 2024 · 4 comments

Comments

@a10y
Copy link
Contributor

a10y commented Dec 12, 2024

We allow consumers of ArrayData to get the list of all children, we should also make it possible to get the list of child names.

Mostly useful for tools that want to interpret vortex files to have a more useful name then child[0], child[1] etc.

@gatesn
Copy link
Contributor

gatesn commented Dec 12, 2024

Screenshot 2024-12-12 at 23 14 36

We sort of do this here, it wouldn't be hard to impl your own visitor to grab child names or we can augment this one

@a10y
Copy link
Contributor Author

a10y commented Dec 12, 2024

That's recursive though, I just want the immediate children

@a10y
Copy link
Contributor Author

a10y commented Dec 12, 2024

Like I want the names version of pub fn children(&self) -> Vec<ArrayData>

@joseph-isaacs
Copy link
Member

Was working on this as part of something else, see (#1710)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants