Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement subtract_scalar_fn for ConstantEncoding #1591

Open
doki23 opened this issue Dec 6, 2024 · 0 comments
Open

implement subtract_scalar_fn for ConstantEncoding #1591

doki23 opened this issue Dec 6, 2024 · 0 comments

Comments

@doki23
Copy link
Contributor

doki23 commented Dec 6, 2024 •
edited
Loading

While implementing FoR compare, I've observed that the subtract_scalar_fn isn't implemented for ConstantEncoding yet. Here's my proposal:

  1. Implement a subtract($self, other: $PrimitiveScalar) function for PrimitiveScalar.
  2. Obtain a new Scalar using lhs.scalar().as_primitive().subtract(another_primitive_scalar).
  3. Utilize the new Scalar to create a new ConstantArray.
@doki23 doki23 changed the title implement subtract_scalar_fn for ChunkedEncoding implement subtract_scalar_fn for ConstantEncoding Dec 6, 2024
@doki23 doki23 mentioned this issue Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doki23