Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow index type made random access much slower #1589

Open
robert3005 opened this issue Dec 6, 2024 · 3 comments
Open

Narrow index type made random access much slower #1589

robert3005 opened this issue Dec 6, 2024 · 3 comments

Comments

@robert3005
Copy link
Member

robert3005 commented Dec 6, 2024

We should investigate why #1558 made random access benchmark 50% slower

@gatesn
Copy link
Contributor

gatesn commented Dec 6, 2024

Do you know specifically where the regression is? We do the widening with a cast in to_arrow, and I made the cast function fall back to canonicalize+cast, so we could just be missing a few cast implementations.

@robert3005
Copy link
Member Author

I haven’t looked at profile. This is speculation given the changes merged that caused slow down

@gatesn
Copy link
Contributor

gatesn commented Dec 6, 2024

So yeah, agree we should investigate and fix, not sure I agree with the proposed fix sans investigation

@robert3005 robert3005 changed the title Support index widening when decompressing Narrow index type made random access much slower Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants