Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide a unified loading API for databases #978

Closed
ctb opened this issue May 3, 2020 · 2 comments · Fixed by #1059
Closed

provide a unified loading API for databases #978

ctb opened this issue May 3, 2020 · 2 comments · Fixed by #1059

Comments

@ctb
Copy link
Contributor

ctb commented May 3, 2020 •
edited
Loading

There are a number of issues - #672 is the motivating one, but also see #949 and #849 - that suggest to me that we could usefully use a single common API for loading databases, and/or modifying them. This is the unifying issue :).
@ctb ctb mentioned this issue May 3, 2020
Closed
@ctb ctb mentioned this issue Jun 26, 2020
Closed
@ctb
Copy link
Contributor Author

ctb commented Jun 26, 2020 •
edited
Loading

see also #1044 which gets closer. #875 is relevant. Could add or extend selector foo (#599, #936).

@ctb
Copy link
Contributor Author

ctb commented Jun 28, 2020 •
edited
Loading

#1059 is a solid first pass at resolving the loading part of this issue - see sourmash_args.load_file_as_index.

@ctb ctb mentioned this issue Jun 29, 2020
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use new load_file_as_signatures function more broadly sourmash-bio/sourmash
1 participant
@ctb