Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder sbt gather/search arguments? #231

Closed
ctb opened this issue May 17, 2017 · 3 comments
Closed

reorder sbt gather/search arguments? #231

ctb opened this issue May 17, 2017 · 3 comments

Comments

@ctb
Copy link
Contributor

ctb commented May 17, 2017

I've never been happy with the order of the sbt_search and sbt_gather arguments; currently, they take SBT first, query signature second:

sourmash sbt_search genbank.sbt.json query.sig

and my fingers always want the arguments to be the other way around.

In thinking about #229, I'm wondering if we should just change the order like so:

sourmash sbt_search query.sig genbank.sbt.json

which would then support multiple SBTs more naturally:

sourmash sbt_search query.sig genbank.sbt.json foo.sbt.json bar.sbt.json

any thoughts @luizirber @taylorreiter @brooksph?

Hmm, we could even combine search and sbt_search by allowing search to take both SBTs and individual signatures. Whaddya think? Too confusing?

@luizirber
Copy link
Member

Did anyone ever try to use sbt_search (or search) with more than one query sig? I think inverting is a good idea.

I also like the idea of combining search and sbt_search!

@brooksph
Copy link
Contributor

brooksph commented May 17, 2017

I agree that the following order is more natural:

sourmash sbt_search query.sig genbank.sbt.json

I often type it that way at first. Searching multiple SBTs is useful but should probably be accompanied by multiple outputs or an output format that identifies the sbt where the match was found.

@ctb
Copy link
Contributor Author

ctb commented May 21, 2017

Closed by #240.

@ctb ctb closed this as completed May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants