Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containment vs resemblance? #127

Closed
ctb opened this issue Jan 25, 2017 · 3 comments
Closed

containment vs resemblance? #127

ctb opened this issue Jan 25, 2017 · 3 comments

Comments

@ctb
Copy link
Contributor

ctb commented Jan 25, 2017

sourmash search functions currently compute containment, rather than resemblance - see #125.

What does mash do? Our defaults (absent any other reason) should be similar. And maybe we want to provide a command line switch? Or at the very least document what we do properly :)
@ctb
Copy link
Contributor Author

ctb commented Apr 4, 2017

#150 changes this so that we calculate the Jaccard index using intersection over union.

@ctb ctb mentioned this issue Apr 18, 2017
Closed
@ctb
Copy link
Contributor Author

ctb commented Apr 18, 2017

I think we want search functions to optionally support containment, which is useful in metagenomics. But #150 makes resemblance the default, which is appropriate.

@ctb ctb mentioned this issue Apr 19, 2017
Closed
@ctb
Copy link
Contributor Author

ctb commented Apr 19, 2017

Closed in favor of #182.

@ctb ctb closed this as completed Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb