Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize new filter list management menu items to non-English languages #2

Open
chrissimpkins opened this issue Jul 24, 2018 · 5 comments

Comments

@chrissimpkins
Copy link
Member

chrissimpkins commented Jul 24, 2018

What languages? Need native speaker/writer assistance to support this.

Will need language codes for all languages that we support: https://docu.glyphsapp.com/#localize

@chrissimpkins
Copy link
Member Author

chrissimpkins commented Jul 29, 2018

@schriftgestalt @mekkablue Is there a list of the two letter dict key codes that you support in the Glyphs.localize method? When I print Glyphs.defaults[“AppleLanguages”] through a script in my editor, it only shows en-us...

Related IR: #3

Thanks!

@chrissimpkins
Copy link
Member Author

chrissimpkins commented Jul 30, 2018

German:

@jublo the source for the plugin is in the Python source file FilterListManager.glyphsPlugin/Contents/Resources/plugin.py and localized strings are defined in the Glyphs.localize methods like the following (which are the definitions for the three Glyphs Edit menu item strings used by the plugin):

self.update_name = Glyphs.localize(
{"en": u"Update Filter Lists", "de": u"XXXX"}
)
self.restoredefault_name = Glyphs.localize(
{"en": u"Restore Default Filter Lists", "de": u"XXXX"}
)
self.opendir_name = Glyphs.localize(
{"en": u"Open GlyphsFilters Directory", "de": u"XXXX"}
)

@chrissimpkins
Copy link
Member Author

chrissimpkins commented Jul 30, 2018

@jublo I just pushed v0.4.1 to remove the undefined German menu item strings. This was a placeholder to remind myself about how they were defined and forgot about this. Until defined, the source linked above will lead to our German language user crowd seeing a bunch of XXXX's as their menu items... Fixed until you have a chance to push new strings. If you modify the source, make sure that they are Python unicode strings. Glyphs is using Python 2.7.x and it must be formatted as shown above. ty!

@schriftgestalt
Copy link
Contributor

This is the full list of languages that are supposed by Glyphs:
"cs", "de", "en", "es", "fr", "it", "ja", "ko", "pt", "ru", "tr", "zh_CN", "zh-Hant"

@chrissimpkins
Copy link
Member Author

Thank you @schriftgestalt!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants